1999-03-09 22:27:43 +00:00
/*
* BIRD -- OSPF Configuration
*
2004-07-13 13:52:54 +00:00
* (c) 1999--2004 Ondrej Filip <feela@network.cz>
1999-03-09 22:27:43 +00:00
*
* Can be freely distributed and used under the terms of the GNU GPL.
*/
CF_HDR
#include "proto/ospf/ospf.h"
2000-06-02 15:05:41 +00:00
CF_DEFINES
#define OSPF_CFG ((struct ospf_config *) this_proto)
2000-06-03 01:29:00 +00:00
#define OSPF_PATT ((struct ospf_iface_patt *) this_ipatt)
2009-05-06 20:02:45 +00:00
static struct ospf_area_config *this_area;
2000-06-05 23:44:26 +00:00
static struct nbma_node *this_nbma;
2011-08-07 23:45:31 +00:00
static list *this_nets;
2004-06-25 16:39:53 +00:00
static struct area_net_config *this_pref;
2014-07-21 19:50:56 +00:00
static struct ospf_stubnet_config *this_stubnet;
2000-06-02 15:05:41 +00:00
2014-06-26 09:58:57 +00:00
static inline int ospf_cfg_is_v2(void) { return OSPF_CFG->ospf2; }
static inline int ospf_cfg_is_v3(void) { return ! OSPF_CFG->ospf2; }
2009-04-08 18:15:01 +00:00
static void
2011-03-17 14:53:36 +00:00
ospf_iface_finish(void)
2009-04-08 18:15:01 +00:00
{
2011-03-17 14:53:36 +00:00
struct ospf_iface_patt *ip = OSPF_PATT;
if (ip->deadint == 0)
ip->deadint = ip->deadc * ip->helloint;
2014-07-21 19:50:56 +00:00
if (ip->waitint == 0)
ip->waitint = ip->deadc * ip->helloint;
2009-04-08 18:15:01 +00:00
ip->passwords = get_passwords();
2018-04-25 13:50:57 +00:00
if (ospf_cfg_is_v2() && (ip->autype == OSPF_AUTH_CRYPT) && (ip->helloint < 5))
2023-06-16 20:11:03 +00:00
cf_warn("Hello or poll interval less that 5 makes cryptographic authenication prone to replay attacks");
2009-04-08 18:15:01 +00:00
if ((ip->autype == OSPF_AUTH_NONE) && (ip->passwords != NULL))
2023-06-16 20:11:03 +00:00
cf_warn("Password option without authentication option does not make sense");
2016-10-27 18:58:21 +00:00
if (ip->passwords)
{
struct password_item *pass;
WALK_LIST(pass, *ip->passwords)
{
if (pass->alg && (ip->autype != OSPF_AUTH_CRYPT))
cf_error("Password algorithm option requires cryptographic authentication");
/* Set default OSPF crypto algorithms */
if (!pass->alg && (ip->autype == OSPF_AUTH_CRYPT))
pass->alg = ospf_cfg_is_v2() ? ALG_MD5 : ALG_HMAC_SHA256;
2018-04-25 13:50:57 +00:00
if (ospf_cfg_is_v3() && ip->autype && (pass->alg < ALG_HMAC))
cf_error("Keyed hash algorithms are not allowed, use HMAC algorithms");
2016-10-27 18:58:21 +00:00
}
}
2009-04-08 18:15:01 +00:00
}
2011-03-17 14:53:36 +00:00
static void
ospf_area_finish(void)
{
2011-07-20 21:40:20 +00:00
if ((this_area->areaid == 0) && (this_area->type != OPT_E))
2011-09-03 19:31:26 +00:00
cf_error("Backbone area cannot be stub/NSSA");
if (this_area->summary && (this_area->type == OPT_E))
2014-06-26 09:58:57 +00:00
cf_error("Only stub/NSSA areas can use summary propagation");
2011-09-03 19:31:26 +00:00
if (this_area->default_nssa && ((this_area->type != OPT_N) || ! this_area->summary))
cf_error("Only NSSA areas with summary propagation can use NSSA default route");
2014-06-26 09:58:57 +00:00
if ((this_area->default_cost & LSA_EXT3_EBIT) && ! this_area->default_nssa)
2011-09-03 19:31:26 +00:00
cf_error("Only NSSA default route can use type 2 metric");
2011-03-17 14:53:36 +00:00
}
static void
ospf_proto_finish(void)
{
struct ospf_config *cf = OSPF_CFG;
2017-10-08 23:16:29 +00:00
struct ospf_area_config *ac;
struct ospf_iface_patt *ic;
2011-03-17 14:53:36 +00:00
2016-01-26 10:48:58 +00:00
/* Define default channel */
2021-06-17 14:56:51 +00:00
if (! proto_cf_main_channel(this_proto))
2017-10-08 23:16:29 +00:00
{
2018-01-09 17:42:22 +00:00
uint net_type = this_proto->net_type = ospf_cfg_is_v2() ? NET_IP4 : NET_IP6;
channel_config_new(NULL, net_label[net_type], net_type, this_proto);
2017-10-08 23:16:29 +00:00
}
/* Propagate global instance ID to interfaces */
if (cf->instance_id_set)
{
WALK_LIST(ac, cf->area_list)
WALK_LIST(ic, ac->patt_list)
if (!ic->instance_id_set)
{ ic->instance_id = cf->instance_id; ic->instance_id_set = 1; }
WALK_LIST(ic, cf->vlink_list)
if (!ic->instance_id_set)
{ ic->instance_id = cf->instance_id; ic->instance_id_set = 1; }
}
if (ospf_cfg_is_v3())
{
uint ipv4 = (this_proto->net_type == NET_IP4);
uint base = (ipv4 ? 64 : 0) + (cf->af_mc ? 32 : 0);
/* RFC 5838 - OSPFv3-AF */
if (cf->af_ext)
{
/* RFC 5838 2.1 - instance IDs based on AFs */
WALK_LIST(ac, cf->area_list)
WALK_LIST(ic, ac->patt_list)
{
if (!ic->instance_id_set)
ic->instance_id = base;
else if (ic->instance_id >= 128)
2023-06-16 20:11:03 +00:00
cf_warn("Instance ID %d from unassigned/private range", ic->instance_id);
2017-10-08 23:16:29 +00:00
else if ((ic->instance_id < base) || (ic->instance_id >= (base + 32)))
cf_error("Instance ID %d invalid for given channel type", ic->instance_id);
}
/* RFC 5838 2.8 - vlinks limited to IPv6 unicast */
if ((ipv4 || cf->af_mc) && !EMPTY_LIST(cf->vlink_list))
cf_error("Vlinks not supported in AFs other than IPv6 unicast");
}
else
{
if (ipv4 || cf->af_mc)
cf_error("Different channel type");
}
}
if (EMPTY_LIST(cf->area_list))
cf_error("No configured areas in OSPF");
2016-01-26 10:48:58 +00:00
2011-03-17 14:53:36 +00:00
int areano = 0;
int backbone = 0;
2014-06-26 09:58:57 +00:00
int nssa = 0;
2011-03-17 14:53:36 +00:00
WALK_LIST(ac, cf->area_list)
{
areano++;
if (ac->areaid == 0)
2014-06-26 09:58:57 +00:00
backbone = 1;
if (ac->type == OPT_N)
nssa = 1;
2011-03-17 14:53:36 +00:00
}
2014-06-26 09:58:57 +00:00
2011-03-17 14:53:36 +00:00
cf->abr = areano > 1;
2014-06-26 09:58:57 +00:00
/* Route export or NSSA translation (RFC 3101 3.1) */
2016-01-26 10:48:58 +00:00
cf->asbr = (proto_cf_main_channel(this_proto)->out_filter != FILTER_REJECT) || (nssa && cf->abr);
2014-06-26 09:58:57 +00:00
2011-03-17 14:53:36 +00:00
if (cf->abr && !backbone)
{
struct ospf_area_config *ac = cfg_allocz(sizeof(struct ospf_area_config));
2012-10-29 19:29:31 +00:00
ac->type = OPT_E; /* Backbone is non-stub */
2011-03-17 14:53:36 +00:00
add_head(&cf->area_list, NODE ac);
init_list(&ac->patt_list);
init_list(&ac->net_list);
2011-08-07 23:45:31 +00:00
init_list(&ac->enet_list);
2011-03-17 14:53:36 +00:00
init_list(&ac->stubnet_list);
}
if (!cf->abr && !EMPTY_LIST(cf->vlink_list))
2014-06-26 09:58:57 +00:00
cf_error("Vlinks cannot be used on single area router");
if (cf->asbr && (areano == 1) && (this_area->type == 0))
cf_error("ASBR must be in non-stub area");
2011-03-17 14:53:36 +00:00
}
2011-09-03 19:31:26 +00:00
static inline void
2014-06-26 09:58:57 +00:00
ospf_check_defcost(int cost)
2011-09-03 19:31:26 +00:00
{
if ((cost <= 0) || (cost >= LSINFINITY))
2017-05-23 15:22:53 +00:00
cf_error("Default cost must be in range 1-%u", LSINFINITY-1);
2012-05-11 16:52:59 +00:00
}
static inline void
2014-06-26 09:58:57 +00:00
ospf_check_auth(void)
2012-05-11 16:52:59 +00:00
{
2014-06-26 09:58:57 +00:00
if (ospf_cfg_is_v3())
2018-04-25 13:50:57 +00:00
cf_error("Plaintext authentication not supported in OSPFv3");
2011-09-03 19:31:26 +00:00
}
2014-06-26 09:58:57 +00:00
1999-03-09 22:27:43 +00:00
CF_DECLS
2022-12-13 18:31:46 +00:00
CF_KEYWORDS_EXCLUSIVE(V2, V3)
CF_KEYWORDS(OSPF, OSPF_METRIC1, OSPF_METRIC2, OSPF_TAG, OSPF_ROUTER_ID)
2017-03-08 16:37:11 +00:00
CF_KEYWORDS(AREA, NEIGHBORS, RFC1583COMPAT, STUB, TICK, COST, COST2, RETRANSMIT)
2013-09-26 15:36:30 +00:00
CF_KEYWORDS(HELLO, TRANSMIT, PRIORITY, DEAD, TYPE, BROADCAST, BCAST, DEFAULT)
2010-12-24 17:08:07 +00:00
CF_KEYWORDS(NONBROADCAST, NBMA, POINTOPOINT, PTP, POINTOMULTIPOINT, PTMP)
2013-06-25 13:33:00 +00:00
CF_KEYWORDS(NONE, SIMPLE, AUTHENTICATION, STRICT, CRYPTOGRAPHIC, TTL, SECURITY)
2013-11-22 21:49:04 +00:00
CF_KEYWORDS(ELIGIBLE, POLL, NETWORKS, HIDDEN, VIRTUAL, CHECK, LINK, ONLY, BFD)
2011-08-07 23:45:31 +00:00
CF_KEYWORDS(RX, BUFFER, LARGE, NORMAL, STUBNET, HIDDEN, SUMMARY, TAG, EXTERNAL)
2011-07-22 18:00:24 +00:00
CF_KEYWORDS(WAIT, DELAY, LSADB, ECMP, LIMIT, WEIGHT, NSSA, TRANSLATOR, STABILITY)
2014-02-06 16:46:01 +00:00
CF_KEYWORDS(GLOBAL, LSID, ROUTER, SELF, INSTANCE, REAL, NETMASK, TX, PRIORITY, LENGTH)
OSPF: Fix handling of unnumbered PtPs
This issue has a long history. In 2012, we changed data field for
unnumbered PtP links from iface id (specified by RFC) to IP address based
on reports of bugs in Quagga that required it, and we used out-of-band
information to distinquish unnumberred PtPs with the same local IP
address.
Then with OSPF graceful restart implementation, we found that we can no
longer use out-of-band information, and we need to use only LSAdb info
for routing table calculation, but i forgot to finish handling of this
case, so multiple unnumbered PtPs with the same local IP addresses were
broken.
Considering that even recent Mikrotik RouterOS has broken next hop
calculation that depends on IP address in PtP link data field, we
cannot just switch back to the iface id for unnumbered PtP links.
The patch makes two changes: First, it goes back to use out-of-band
(position) info for distinguishing local interfaces in SPF when graceful
restart is not enabled, while still uses LSAdb-only approach for SPF
calculation when graceful restart is enabled.
Second, it adds OSPF interface option 'ptp address', which controls
whether IP address or iface id is used in data field. It is enabled
by default except for unnumbered PtP links with enabled graceful
restart.
Thanks to Kenth Eriksson for the bugreport and Joakim Tjernlund for
suggestions.
2020-05-26 16:21:43 +00:00
CF_KEYWORDS(MERGE, LSA, SUPPRESSION, MULTICAST, RFC5838, VPN, PE, ADDRESS)
2019-06-30 18:12:59 +00:00
CF_KEYWORDS(GRACEFUL, RESTART, AWARE, TIME)
1999-03-09 22:27:43 +00:00
2012-03-16 11:12:26 +00:00
%type <ld> lsadb_args
2017-10-08 23:16:29 +00:00
%type <i> ospf_variant ospf_af_mc nbma_eligible
%type <cc> ospf_channel_start ospf_channel
2000-06-01 17:52:21 +00:00
1999-03-09 22:27:43 +00:00
CF_GRAMMAR
2018-06-26 12:29:03 +00:00
proto: ospf_proto '}' { ospf_proto_finish(); } ;
1999-03-09 22:27:43 +00:00
2015-12-21 02:27:41 +00:00
ospf_variant:
2017-03-08 16:37:11 +00:00
OSPF { $$ = 1; }
| OSPF V2 { $$ = 1; }
| OSPF V3 { $$ = 0; }
2015-12-21 02:27:41 +00:00
;
2016-01-26 10:48:58 +00:00
ospf_proto_start: proto_start ospf_variant
{
this_proto = proto_config_new(&proto_ospf, $1);
2017-10-08 23:16:29 +00:00
this_proto->net_type = $2 ? NET_IP4 : 0;
2016-01-26 10:48:58 +00:00
init_list(&OSPF_CFG->area_list);
init_list(&OSPF_CFG->vlink_list);
2017-12-08 14:59:44 +00:00
OSPF_CFG->ecmp = rt_default_ecmp;
2016-01-26 10:48:58 +00:00
OSPF_CFG->tick = OSPF_DEFAULT_TICK;
OSPF_CFG->ospf2 = $2;
2017-10-08 23:16:29 +00:00
OSPF_CFG->af_ext = !$2;
2019-06-30 18:12:59 +00:00
OSPF_CFG->gr_mode = OSPF_GR_AWARE;
OSPF_CFG->gr_time = OSPF_DEFAULT_GR_TIME;
2016-01-26 10:48:58 +00:00
};
1999-03-09 22:27:43 +00:00
ospf_proto:
ospf_proto_start proto_name '{'
2000-06-05 18:32:51 +00:00
| ospf_proto ospf_proto_item ';'
;
2017-10-08 23:16:29 +00:00
ospf_af_mc:
{ $$ = 0; }
| MULTICAST { $$ = 1; }
;
/* We redefine proto_channel to add multicast flag */
ospf_channel_start: net_type ospf_af_mc
{
2018-01-09 17:42:22 +00:00
/* TODO: change name for multicast channels */
$$ = this_channel = channel_config_get(NULL, net_label[$1], $1, this_proto);
2017-10-08 23:16:29 +00:00
/* Save the multicast flag */
2021-06-17 14:56:51 +00:00
OSPF_CFG->af_mc = $2;
2017-10-08 23:16:29 +00:00
};
ospf_channel: ospf_channel_start channel_opt_list channel_end;
2000-06-05 18:32:51 +00:00
ospf_proto_item:
proto_item
2017-10-08 23:16:29 +00:00
| ospf_channel { this_proto->net_type = $1->net_type; }
2004-07-16 07:22:43 +00:00
| RFC1583COMPAT bool { OSPF_CFG->rfc1583 = $2; }
2017-10-10 14:07:54 +00:00
| RFC5838 bool { OSPF_CFG->af_ext = $2; if (!ospf_cfg_is_v3()) cf_error("RFC5838 option requires OSPFv3"); }
2019-02-13 14:40:22 +00:00
| VPN PE bool { OSPF_CFG->vpn_pe = $3; }
2013-06-11 10:12:11 +00:00
| STUB ROUTER bool { OSPF_CFG->stub_router = $3; }
2019-06-30 18:12:59 +00:00
| GRACEFUL RESTART bool { OSPF_CFG->gr_mode = $3; }
| GRACEFUL RESTART AWARE { OSPF_CFG->gr_mode = OSPF_GR_AWARE; }
| GRACEFUL RESTART TIME expr { OSPF_CFG->gr_time = $4; if (($4 < 1) || ($4 > 1800)) cf_error("Graceful restart time must be in range 1-1800"); }
2014-06-26 09:58:57 +00:00
| ECMP bool { OSPF_CFG->ecmp = $2 ? OSPF_DEFAULT_ECMP_LIMIT : 0; }
2017-05-23 15:22:53 +00:00
| ECMP bool LIMIT expr { OSPF_CFG->ecmp = $2 ? $4 : 0; }
2014-04-23 11:54:28 +00:00
| MERGE EXTERNAL bool { OSPF_CFG->merge_external = $3; }
2017-05-23 15:22:53 +00:00
| TICK expr { OSPF_CFG->tick = $2; if($2 <= 0) cf_error("Tick must be greater than zero"); }
2017-10-08 23:16:29 +00:00
| INSTANCE ID expr { OSPF_CFG->instance_id = $3; OSPF_CFG->instance_id_set = 1; if ($3 > 255) cf_error("Instance ID must be in range 0-255"); }
2011-03-17 14:53:36 +00:00
| ospf_area
2000-06-05 18:32:51 +00:00
;
1999-03-09 22:27:43 +00:00
2011-03-17 14:53:36 +00:00
ospf_area_start: AREA idval {
2000-06-02 19:55:55 +00:00
this_area = cfg_allocz(sizeof(struct ospf_area_config));
add_tail(&OSPF_CFG->area_list, NODE this_area);
this_area->areaid = $2;
2014-06-26 09:58:57 +00:00
this_area->default_cost = OSPF_DEFAULT_STUB_COST;
2011-07-20 21:40:20 +00:00
this_area->type = OPT_E;
2014-06-26 09:58:57 +00:00
this_area->transint = OSPF_DEFAULT_TRANSINT;
2011-07-20 21:40:20 +00:00
2000-06-03 01:29:00 +00:00
init_list(&this_area->patt_list);
2001-08-12 00:04:42 +00:00
init_list(&this_area->net_list);
2011-08-07 23:45:31 +00:00
init_list(&this_area->enet_list);
2009-06-11 15:25:38 +00:00
init_list(&this_area->stubnet_list);
1999-03-09 22:27:43 +00:00
}
2000-06-05 18:32:51 +00:00
;
2000-06-01 17:52:21 +00:00
2011-03-17 14:53:36 +00:00
ospf_area: ospf_area_start '{' ospf_area_opts '}' { ospf_area_finish(); }
2000-06-05 18:32:51 +00:00
;
2000-06-03 08:42:04 +00:00
ospf_area_opts:
2000-06-05 18:32:51 +00:00
/* empty */
| ospf_area_opts ospf_area_item ';'
;
2000-06-03 08:42:04 +00:00
2000-06-02 19:55:55 +00:00
ospf_area_item:
2011-09-03 19:31:26 +00:00
STUB bool { this_area->type = $2 ? 0 : OPT_E; /* We should remove the option */ }
2011-07-20 21:40:20 +00:00
| NSSA { this_area->type = OPT_N; }
| SUMMARY bool { this_area->summary = $2; }
2011-09-03 19:31:26 +00:00
| DEFAULT NSSA bool { this_area->default_nssa = $3; }
2014-06-26 09:58:57 +00:00
| DEFAULT COST expr { this_area->default_cost = $3; ospf_check_defcost($3); }
| DEFAULT COST2 expr { this_area->default_cost = $3 | LSA_EXT3_EBIT; ospf_check_defcost($3); }
| STUB COST expr { this_area->default_cost = $3; ospf_check_defcost($3); }
2011-07-22 18:00:24 +00:00
| TRANSLATOR bool { this_area->translator = $2; }
2011-08-07 23:45:31 +00:00
| TRANSLATOR STABILITY expr { this_area->transint = $3; }
| NETWORKS { this_nets = &this_area->net_list; } '{' pref_list '}'
| EXTERNAL { this_nets = &this_area->enet_list; } '{' pref_list '}'
2009-06-11 15:25:38 +00:00
| STUBNET ospf_stubnet
2009-05-06 20:02:45 +00:00
| INTERFACE ospf_iface
2004-07-14 21:46:20 +00:00
| ospf_vlink
2000-06-05 18:32:51 +00:00
;
2000-06-03 01:29:00 +00:00
2009-06-11 15:25:38 +00:00
ospf_stubnet:
ospf_stubnet_start '{' ospf_stubnet_opts '}'
| ospf_stubnet_start
;
ospf_stubnet_start:
2015-11-12 01:03:59 +00:00
net_ip {
2009-06-18 12:32:44 +00:00
this_stubnet = cfg_allocz(sizeof(struct ospf_stubnet_config));
2009-06-11 15:25:38 +00:00
add_tail(&this_area->stubnet_list, NODE this_stubnet);
2015-12-24 14:52:03 +00:00
this_stubnet->prefix = $1;
2009-06-11 15:25:38 +00:00
this_stubnet->cost = COST_D;
2014-07-21 19:50:56 +00:00
}
2009-06-11 15:25:38 +00:00
;
ospf_stubnet_opts:
/* empty */
| ospf_stubnet_opts ospf_stubnet_item ';'
;
ospf_stubnet_item:
HIDDEN bool { this_stubnet->hidden = $2; }
| SUMMARY bool { this_stubnet->summary = $2; }
| COST expr { this_stubnet->cost = $2; }
;
2004-07-14 21:46:20 +00:00
ospf_vlink:
2012-05-11 16:52:59 +00:00
ospf_vlink_start ospf_instance_id '{' ospf_vlink_opts '}' { ospf_iface_finish(); }
| ospf_vlink_start ospf_instance_id { ospf_iface_finish(); }
2004-06-25 16:39:53 +00:00
;
ospf_vlink_opts:
/* empty */
| ospf_vlink_opts ospf_vlink_item ';'
;
ospf_vlink_item:
2004-07-14 21:46:20 +00:00
| HELLO expr { OSPF_PATT->helloint = $2 ; if (($2<=0) || ($2>65535)) cf_error("Hello interval must be in range 1-65535"); }
2014-07-21 19:50:56 +00:00
| RETRANSMIT expr { OSPF_PATT->rxmtint = $2 ; if ($2<=1) cf_error("Retransmit int must be greater than one"); }
2004-06-25 16:39:53 +00:00
| TRANSMIT DELAY expr { OSPF_PATT->inftransdelay = $3 ; if (($3<=0) || ($3>65535)) cf_error("Transmit delay must be in range 1-65535"); }
2014-07-21 19:50:56 +00:00
| WAIT expr { OSPF_PATT->waitint = $2 ; if ($2<=1) cf_error("Wait interval must be greater than one"); }
2011-03-17 14:53:36 +00:00
| DEAD expr { OSPF_PATT->deadint = $2 ; if ($2<=1) cf_error("Dead interval must be greater than one"); }
2004-06-25 16:39:53 +00:00
| DEAD COUNT expr { OSPF_PATT->deadc = $3 ; if ($3<=1) cf_error("Dead count must be greater than one"); }
2014-06-26 09:58:57 +00:00
| AUTHENTICATION NONE { OSPF_PATT->autype = OSPF_AUTH_NONE; }
| AUTHENTICATION SIMPLE { OSPF_PATT->autype = OSPF_AUTH_SIMPLE; ospf_check_auth(); }
2018-04-25 13:50:57 +00:00
| AUTHENTICATION CRYPTOGRAPHIC { OSPF_PATT->autype = OSPF_AUTH_CRYPT; }
| password_list
2004-06-25 16:39:53 +00:00
;
2004-07-14 21:46:20 +00:00
ospf_vlink_start: VIRTUAL LINK idval
2004-06-25 16:39:53 +00:00
{
if (this_area->areaid == 0) cf_error("Virtual link cannot be in backbone");
this_ipatt = cfg_allocz(sizeof(struct ospf_iface_patt));
2011-03-17 14:53:36 +00:00
add_tail(&OSPF_CFG->vlink_list, NODE this_ipatt);
2009-05-06 20:02:45 +00:00
init_list(&this_ipatt->ipn_list);
2011-03-17 14:53:36 +00:00
OSPF_PATT->voa = this_area->areaid;
2004-07-14 21:46:20 +00:00
OSPF_PATT->vid = $3;
2004-06-25 16:39:53 +00:00
OSPF_PATT->helloint = HELLOINT_D;
OSPF_PATT->rxmtint = RXMTINT_D;
OSPF_PATT->inftransdelay = INFTRANSDELAY_D;
OSPF_PATT->deadc = DEADC_D;
OSPF_PATT->type = OSPF_IT_VLINK;
2004-07-14 21:46:20 +00:00
init_list(&OSPF_PATT->nbma_list);
2009-04-08 18:15:01 +00:00
reset_passwords();
2004-06-25 16:39:53 +00:00
}
;
2000-06-03 01:29:00 +00:00
ospf_iface_item:
2004-06-09 12:39:49 +00:00
COST expr { OSPF_PATT->cost = $2 ; if (($2<=0) || ($2>65535)) cf_error("Cost must be in range 1-65535"); }
| HELLO expr { OSPF_PATT->helloint = $2 ; if (($2<=0) || ($2>65535)) cf_error("Hello interval must be in range 1-65535"); }
| POLL expr { OSPF_PATT->pollint = $2 ; if ($2<=0) cf_error("Poll int must be greater than zero"); }
2014-07-21 19:50:56 +00:00
| RETRANSMIT expr { OSPF_PATT->rxmtint = $2 ; if ($2<=1) cf_error("Retransmit int must be greater than one"); }
| WAIT expr { OSPF_PATT->waitint = $2 ; if ($2<=1) cf_error("Wait interval must be greater than one"); }
2011-03-17 14:53:36 +00:00
| DEAD expr { OSPF_PATT->deadint = $2 ; if ($2<=1) cf_error("Dead interval must be greater than one"); }
2004-06-09 12:39:49 +00:00
| DEAD COUNT expr { OSPF_PATT->deadc = $3 ; if ($3<=1) cf_error("Dead count must be greater than one"); }
2000-06-03 09:50:31 +00:00
| TYPE BROADCAST { OSPF_PATT->type = OSPF_IT_BCAST ; }
2010-12-24 17:08:07 +00:00
| TYPE BCAST { OSPF_PATT->type = OSPF_IT_BCAST ; }
2000-06-03 09:50:31 +00:00
| TYPE NONBROADCAST { OSPF_PATT->type = OSPF_IT_NBMA ; }
2010-12-24 17:08:07 +00:00
| TYPE NBMA { OSPF_PATT->type = OSPF_IT_NBMA ; }
2000-06-03 09:50:31 +00:00
| TYPE POINTOPOINT { OSPF_PATT->type = OSPF_IT_PTP ; }
2010-12-24 17:08:07 +00:00
| TYPE PTP { OSPF_PATT->type = OSPF_IT_PTP ; }
| TYPE POINTOMULTIPOINT { OSPF_PATT->type = OSPF_IT_PTMP ; }
| TYPE PTMP { OSPF_PATT->type = OSPF_IT_PTMP ; }
2014-06-26 09:58:57 +00:00
| REAL BROADCAST bool { OSPF_PATT->real_bcast = $3; if (!ospf_cfg_is_v2()) cf_error("Real broadcast option requires OSPFv2"); }
| PTP NETMASK bool { OSPF_PATT->ptp_netmask = $3; if (!ospf_cfg_is_v2()) cf_error("PtP netmask option requires OSPFv2"); }
OSPF: Fix handling of unnumbered PtPs
This issue has a long history. In 2012, we changed data field for
unnumbered PtP links from iface id (specified by RFC) to IP address based
on reports of bugs in Quagga that required it, and we used out-of-band
information to distinquish unnumberred PtPs with the same local IP
address.
Then with OSPF graceful restart implementation, we found that we can no
longer use out-of-band information, and we need to use only LSAdb info
for routing table calculation, but i forgot to finish handling of this
case, so multiple unnumbered PtPs with the same local IP addresses were
broken.
Considering that even recent Mikrotik RouterOS has broken next hop
calculation that depends on IP address in PtP link data field, we
cannot just switch back to the iface id for unnumbered PtP links.
The patch makes two changes: First, it goes back to use out-of-band
(position) info for distinguishing local interfaces in SPF when graceful
restart is not enabled, while still uses LSAdb-only approach for SPF
calculation when graceful restart is enabled.
Second, it adds OSPF interface option 'ptp address', which controls
whether IP address or iface id is used in data field. It is enabled
by default except for unnumbered PtP links with enabled graceful
restart.
Thanks to Kenth Eriksson for the bugreport and Joakim Tjernlund for
suggestions.
2020-05-26 16:21:43 +00:00
| PTP ADDRESS bool { OSPF_PATT->ptp_address = $3; if (!ospf_cfg_is_v2()) cf_error("PtP address option requires OSPFv2"); }
2011-03-17 14:53:36 +00:00
| TRANSMIT DELAY expr { OSPF_PATT->inftransdelay = $3 ; if (($3<=0) || ($3>65535)) cf_error("Transmit delay must be in range 1-65535"); }
2017-05-23 15:22:53 +00:00
| PRIORITY expr { OSPF_PATT->priority = $2 ; if ($2>255) cf_error("Priority must be in range 0-255"); }
2000-09-02 00:03:36 +00:00
| STRICT NONBROADCAST bool { OSPF_PATT->strictnbma = $3 ; }
2000-09-02 08:54:40 +00:00
| STUB bool { OSPF_PATT->stub = $2 ; }
2010-11-19 12:46:21 +00:00
| CHECK LINK bool { OSPF_PATT->check_link = $3; }
2010-12-07 22:35:39 +00:00
| ECMP WEIGHT expr { OSPF_PATT->ecmp_weight = $3 - 1; if (($3<1) || ($3>256)) cf_error("ECMP weight must be in range 1-256"); }
2014-06-26 09:58:57 +00:00
| LINK LSA SUPPRESSION bool { OSPF_PATT->link_lsa_suppression = $4; if (!ospf_cfg_is_v3()) cf_error("Link LSA suppression option requires OSPFv3"); }
2013-04-16 14:22:31 +00:00
| NEIGHBORS '{' nbma_list '}'
2014-06-26 09:58:57 +00:00
| AUTHENTICATION NONE { OSPF_PATT->autype = OSPF_AUTH_NONE; }
| AUTHENTICATION SIMPLE { OSPF_PATT->autype = OSPF_AUTH_SIMPLE; ospf_check_auth(); }
2018-04-25 13:50:57 +00:00
| AUTHENTICATION CRYPTOGRAPHIC { OSPF_PATT->autype = OSPF_AUTH_CRYPT; }
2014-07-21 19:50:56 +00:00
| RX BUFFER NORMAL { OSPF_PATT->rx_buffer = 0; }
| RX BUFFER LARGE { OSPF_PATT->rx_buffer = OSPF_MAX_PKT_SIZE; }
2014-02-06 16:46:01 +00:00
| RX BUFFER expr { OSPF_PATT->rx_buffer = $3; if (($3 < OSPF_MIN_PKT_SIZE) || ($3 > OSPF_MAX_PKT_SIZE)) cf_error("Buffer size must be in range 256-65535"); }
2013-06-24 14:37:30 +00:00
| TX tos { OSPF_PATT->tx_tos = $2; }
| TX PRIORITY expr { OSPF_PATT->tx_priority = $3; }
2014-02-06 16:46:01 +00:00
| TX LENGTH expr { OSPF_PATT->tx_length = $3; if (($3 < OSPF_MIN_PKT_SIZE) || ($3 > OSPF_MAX_PKT_SIZE)) cf_error("TX length must be in range 256-65535"); }
2013-06-25 13:33:00 +00:00
| TTL SECURITY bool { OSPF_PATT->ttl_security = $3; }
| TTL SECURITY TX ONLY { OSPF_PATT->ttl_security = 2; }
2013-11-19 21:33:48 +00:00
| BFD bool { OSPF_PATT->bfd = $2; cf_check_bfd($2); }
2018-04-25 13:50:57 +00:00
| password_list
2000-06-05 18:32:51 +00:00
;
2000-06-05 23:44:26 +00:00
2001-08-12 00:04:42 +00:00
pref_list:
/* empty */
| pref_list pref_item
;
2011-08-07 23:45:31 +00:00
pref_item: pref_base pref_opt ';' ;
2001-08-12 00:04:42 +00:00
2015-11-12 01:03:59 +00:00
pref_base: net_ip
2001-08-12 00:04:42 +00:00
{
2004-06-25 16:39:53 +00:00
this_pref = cfg_allocz(sizeof(struct area_net_config));
2011-08-07 23:45:31 +00:00
add_tail(this_nets, NODE this_pref);
2015-12-24 14:52:03 +00:00
this_pref->prefix = $1;
2001-08-12 00:04:42 +00:00
}
;
2011-08-07 23:45:31 +00:00
pref_opt:
/* empty */
| HIDDEN { this_pref->hidden = 1; }
| TAG expr { this_pref->tag = $2; }
;
2001-08-12 00:04:42 +00:00
2013-04-16 14:22:31 +00:00
nbma_list:
2000-06-05 23:44:26 +00:00
/* empty */
2013-04-16 14:22:31 +00:00
| nbma_list nbma_item
2000-06-05 23:44:26 +00:00
;
2000-09-02 00:03:36 +00:00
2013-04-16 14:22:31 +00:00
nbma_eligible:
/* empty */ { $$ = 0; }
| ELIGIBLE { $$ = 1; }
;
2014-07-21 19:50:56 +00:00
2014-06-26 09:58:57 +00:00
nbma_item: ipa nbma_eligible ';'
2000-09-02 00:03:36 +00:00
{
this_nbma = cfg_allocz(sizeof(struct nbma_node));
add_tail(&OSPF_PATT->nbma_list, NODE this_nbma);
this_nbma->ip=$1;
2013-04-16 14:22:31 +00:00
this_nbma->eligible=$2;
2000-09-02 00:03:36 +00:00
}
;
2014-07-21 19:50:56 +00:00
2000-06-03 09:50:31 +00:00
ospf_iface_start:
{
this_ipatt = cfg_allocz(sizeof(struct ospf_iface_patt));
add_tail(&this_area->patt_list, NODE this_ipatt);
2009-05-06 20:02:45 +00:00
init_list(&this_ipatt->ipn_list);
2000-06-03 09:50:31 +00:00
OSPF_PATT->cost = COST_D;
OSPF_PATT->helloint = HELLOINT_D;
2000-09-02 00:03:36 +00:00
OSPF_PATT->pollint = POLLINT_D;
2000-06-03 09:50:31 +00:00
OSPF_PATT->rxmtint = RXMTINT_D;
OSPF_PATT->inftransdelay = INFTRANSDELAY_D;
OSPF_PATT->priority = PRIORITY_D;
OSPF_PATT->deadc = DEADC_D;
OSPF_PATT->type = OSPF_IT_UNDEF;
2000-06-05 23:44:26 +00:00
init_list(&OSPF_PATT->nbma_list);
2017-12-08 14:59:44 +00:00
OSPF_PATT->check_link = 1;
2013-04-17 11:06:40 +00:00
OSPF_PATT->ptp_netmask = 2; /* not specified */
OSPF: Fix handling of unnumbered PtPs
This issue has a long history. In 2012, we changed data field for
unnumbered PtP links from iface id (specified by RFC) to IP address based
on reports of bugs in Quagga that required it, and we used out-of-band
information to distinquish unnumberred PtPs with the same local IP
address.
Then with OSPF graceful restart implementation, we found that we can no
longer use out-of-band information, and we need to use only LSAdb info
for routing table calculation, but i forgot to finish handling of this
case, so multiple unnumbered PtPs with the same local IP addresses were
broken.
Considering that even recent Mikrotik RouterOS has broken next hop
calculation that depends on IP address in PtP link data field, we
cannot just switch back to the iface id for unnumbered PtP links.
The patch makes two changes: First, it goes back to use out-of-band
(position) info for distinguishing local interfaces in SPF when graceful
restart is not enabled, while still uses LSAdb-only approach for SPF
calculation when graceful restart is enabled.
Second, it adds OSPF interface option 'ptp address', which controls
whether IP address or iface id is used in data field. It is enabled
by default except for unnumbered PtP links with enabled graceful
restart.
Thanks to Kenth Eriksson for the bugreport and Joakim Tjernlund for
suggestions.
2020-05-26 16:21:43 +00:00
OSPF_PATT->ptp_address = 2; /* not specified */
2013-06-24 14:37:30 +00:00
OSPF_PATT->tx_tos = IP_PREC_INTERNET_CONTROL;
OSPF_PATT->tx_priority = sk_priority_control;
2009-04-08 18:15:01 +00:00
reset_passwords();
2000-06-03 09:50:31 +00:00
}
;
2012-05-11 16:52:59 +00:00
ospf_instance_id:
/* empty */
2017-10-08 23:16:29 +00:00
| INSTANCE expr { OSPF_PATT->instance_id = $2; OSPF_PATT->instance_id_set = 1; if ($2 > 255) cf_error("Instance ID must be in range 0-255"); }
2012-05-11 16:52:59 +00:00
;
2014-03-30 22:56:44 +00:00
ospf_iface_patt_list:
2014-06-26 09:58:57 +00:00
iface_patt_list { if (ospf_cfg_is_v3()) iface_patt_check(); } ospf_instance_id
2014-07-21 19:50:56 +00:00
;
2014-03-30 22:56:44 +00:00
2000-06-03 01:29:00 +00:00
ospf_iface_opts:
2000-06-05 18:32:51 +00:00
/* empty */
2000-06-03 01:29:00 +00:00
| ospf_iface_opts ospf_iface_item ';'
;
2000-06-05 18:32:51 +00:00
ospf_iface_opt_list:
/* empty */
| '{' ospf_iface_opts '}'
;
2000-06-03 01:29:00 +00:00
ospf_iface:
2014-03-30 22:56:44 +00:00
ospf_iface_start ospf_iface_patt_list ospf_iface_opt_list { ospf_iface_finish(); }
2000-06-03 01:29:00 +00:00
;
2019-07-02 22:00:11 +00:00
dynamic_attr: OSPF_METRIC1 { $$ = f_new_dynamic_attr(EAF_TYPE_INT, T_INT, EA_OSPF_METRIC1); } ;
dynamic_attr: OSPF_METRIC2 { $$ = f_new_dynamic_attr(EAF_TYPE_INT, T_INT, EA_OSPF_METRIC2); } ;
dynamic_attr: OSPF_TAG { $$ = f_new_dynamic_attr(EAF_TYPE_INT, T_INT, EA_OSPF_TAG); } ;
dynamic_attr: OSPF_ROUTER_ID { $$ = f_new_dynamic_attr(EAF_TYPE_ROUTER_ID, T_QUAD, EA_OSPF_ROUTER_ID); } ;
2000-05-30 21:25:32 +00:00
2012-03-22 10:46:38 +00:00
CF_CLI_HELP(SHOW OSPF, ..., [[Show information about OSPF protocol]]);
2019-01-30 13:03:47 +00:00
CF_CLI(SHOW OSPF, optproto, [<name>], [[Show information about OSPF protocol]])
2020-05-14 01:48:17 +00:00
{ PROTO_WALK_CMD($3, &proto_ospf, p) ospf_sh(p); };
2000-06-01 16:26:59 +00:00
2019-01-30 13:03:47 +00:00
CF_CLI(SHOW OSPF NEIGHBORS, optproto opttext, [<name>] [\"<interface>\"], [[Show information about OSPF neighbors]])
2020-05-14 01:48:17 +00:00
{ PROTO_WALK_CMD($4, &proto_ospf, p) ospf_sh_neigh(p, $5); };
2000-06-01 17:52:21 +00:00
2019-01-30 13:03:47 +00:00
CF_CLI(SHOW OSPF INTERFACE, optproto opttext, [<name>] [\"<interface>\"], [[Show information about interface]])
2020-05-14 01:48:17 +00:00
{ PROTO_WALK_CMD($4, &proto_ospf, p) ospf_sh_iface(p, $5); };
2000-06-01 15:53:06 +00:00
2010-04-24 13:18:21 +00:00
CF_CLI_HELP(SHOW OSPF TOPOLOGY, [all] [<name>], [[Show information about OSPF network topology]])
2008-10-26 23:03:30 +00:00
2019-01-30 13:03:47 +00:00
CF_CLI(SHOW OSPF TOPOLOGY, optproto opttext, [<name>], [[Show information about reachable OSPF network topology]])
2010-04-24 13:18:21 +00:00
{ ospf_sh_state(proto_get_named($4, &proto_ospf), 0, 1); };
2019-01-30 13:03:47 +00:00
CF_CLI(SHOW OSPF TOPOLOGY ALL, optproto opttext, [<name>], [[Show information about all OSPF network topology]])
2010-04-24 13:18:21 +00:00
{ ospf_sh_state(proto_get_named($5, &proto_ospf), 0, 0); };
CF_CLI_HELP(SHOW OSPF STATE, [all] [<name>], [[Show information about OSPF network state]])
2019-01-30 13:03:47 +00:00
CF_CLI(SHOW OSPF STATE, optproto opttext, [<name>], [[Show information about reachable OSPF network state]])
2010-04-24 13:18:21 +00:00
{ ospf_sh_state(proto_get_named($4, &proto_ospf), 1, 1); };
2019-01-30 13:03:47 +00:00
CF_CLI(SHOW OSPF STATE ALL, optproto opttext, [<name>], [[Show information about all OSPF network state]])
2010-04-24 13:18:21 +00:00
{ ospf_sh_state(proto_get_named($5, &proto_ospf), 1, 0); };
2008-10-26 23:03:30 +00:00
2012-03-22 10:46:38 +00:00
CF_CLI_HELP(SHOW OSPF LSADB, ..., [[Show content of OSPF LSA database]]);
2012-03-16 11:12:26 +00:00
CF_CLI(SHOW OSPF LSADB, lsadb_args, [global | area <id> | link] [type <num>] [lsid <id>] [self | router <id>] [<proto>], [[Show content of OSPF LSA database]])
2019-08-29 18:58:16 +00:00
{
if (!$4->proto)
$4->proto = (struct ospf_proto *) proto_get_named(NULL, &proto_ospf);
ospf_sh_lsadb($4);
};
2012-03-16 11:12:26 +00:00
2024-03-05 18:04:10 +00:00
CF_CLI_OPT(SHOW OSPF LSADB GLOBAL)
CF_CLI_OPT(SHOW OSPF LSADB AREA, <id>)
CF_CLI_OPT(SHOW OSPF LSADB LINK)
CF_CLI_OPT(SHOW OSPF LSADB TYPE, <num>)
CF_CLI_OPT(SHOW OSPF LSADB LSID, <id>)
CF_CLI_OPT(SHOW OSPF LSADB SELF)
CF_CLI_OPT(SHOW OSPF LSADB ROUTER, <id>)
2012-03-16 11:12:26 +00:00
lsadb_args:
/* empty */ {
$$ = cfg_allocz(sizeof(struct lsadb_show_data));
}
| lsadb_args GLOBAL { $$ = $1; $$->scope = LSA_SCOPE_AS; }
2013-02-10 18:04:08 +00:00
| lsadb_args AREA idval { $$ = $1; $$->scope = LSA_SCOPE_AREA; $$->area = $3; }
2012-03-16 11:12:26 +00:00
| lsadb_args LINK { $$ = $1; $$->scope = 1; /* hack, 0 is no filter */ }
| lsadb_args TYPE NUM { $$ = $1; $$->type = $3; }
| lsadb_args LSID idval { $$ = $1; $$->lsid = $3; }
| lsadb_args SELF { $$ = $1; $$->router = SH_ROUTER_SELF; }
| lsadb_args ROUTER idval { $$ = $1; $$->router = $3; }
2019-05-17 20:18:49 +00:00
| lsadb_args CF_SYM_KNOWN { cf_assert_symbol($2, SYM_PROTO); $$ = $1; $$->proto = (struct ospf_proto *) proto_get_named($2, &proto_ospf); }
2012-03-16 11:12:26 +00:00
;
2009-10-15 09:57:25 +00:00
1999-03-09 22:27:43 +00:00
CF_CODE
CF_END