From 1021dae8c0c266d51570b8e8dfe81e108ea4a71e Mon Sep 17 00:00:00 2001
From: Baoshuo <i@baoshuo.ren>
Date: Sat, 2 Apr 2022 18:01:26 +0800
Subject: [PATCH] feat(web): throw 403 when need login

---
 web/app/controllers/add_contest.php                | 2 +-
 web/app/controllers/announcements.php              | 2 +-
 web/app/controllers/blog_show.php                  | 2 +-
 web/app/controllers/blogs.php                      | 2 +-
 web/app/controllers/contest_inside.php             | 2 +-
 web/app/controllers/contest_manage.php             | 2 +-
 web/app/controllers/contest_members.php            | 2 +-
 web/app/controllers/contests.php                   | 2 +-
 web/app/controllers/download.php                   | 2 +-
 web/app/controllers/faq.php                        | 2 +-
 web/app/controllers/hack.php                       | 2 +-
 web/app/controllers/hack_list.php                  | 2 +-
 web/app/controllers/problem.php                    | 2 +-
 web/app/controllers/problem_data_manage.php        | 2 +-
 web/app/controllers/problem_managers_manage.php    | 2 +-
 web/app/controllers/problem_set.php                | 2 +-
 web/app/controllers/problem_statement_manage.php   | 2 +-
 web/app/controllers/problem_statistics.php         | 2 +-
 web/app/controllers/ranklist.php                   | 2 +-
 web/app/controllers/subdomain/blog/aboutme.php     | 2 +-
 web/app/controllers/subdomain/blog/archive.php     | 2 +-
 web/app/controllers/subdomain/blog/blog.php        | 2 +-
 web/app/controllers/subdomain/blog/blog_delete.php | 2 +-
 web/app/controllers/subdomain/blog/blog_write.php  | 2 +-
 web/app/controllers/subdomain/blog/index.php       | 2 +-
 web/app/controllers/subdomain/blog/slide.php       | 2 +-
 web/app/controllers/subdomain/blog/slide_write.php | 2 +-
 web/app/controllers/submission.php                 | 2 +-
 web/app/controllers/submission_status_details.php  | 2 +-
 web/app/controllers/submissions_list.php           | 2 +-
 web/app/controllers/user_info.php                  | 2 +-
 web/app/libs/uoj-html-lib.php                      | 8 ++++----
 32 files changed, 35 insertions(+), 35 deletions(-)

diff --git a/web/app/controllers/add_contest.php b/web/app/controllers/add_contest.php
index dc70f3c..7b4be09 100644
--- a/web/app/controllers/add_contest.php
+++ b/web/app/controllers/add_contest.php
@@ -1,6 +1,6 @@
 <?php
 	if (!Auth::check()) {
-		becomeMsgPage(UOJLocale::get('need login'));
+		become403Page(UOJLocale::get('need login'));
 	}
 
 	requirePHPLib('form');
diff --git a/web/app/controllers/announcements.php b/web/app/controllers/announcements.php
index 057461b..8ec902c 100644
--- a/web/app/controllers/announcements.php
+++ b/web/app/controllers/announcements.php
@@ -1,6 +1,6 @@
 <?php
 	if (!Auth::check()) {
-		becomeMsgPage(UOJLocale::get('need login'));
+		become403Page(UOJLocale::get('need login'));
 	}
 
 	requirePHPLib('form');
diff --git a/web/app/controllers/blog_show.php b/web/app/controllers/blog_show.php
index 8e49669..0195664 100644
--- a/web/app/controllers/blog_show.php
+++ b/web/app/controllers/blog_show.php
@@ -1,6 +1,6 @@
 <?php
 	if (!Auth::check()) {
-		becomeMsgPage(UOJLocale::get('need login'));
+		become403Page(UOJLocale::get('need login'));
 	}
 
 	if (!validateUInt($_GET['id']) || !($blog = queryBlog($_GET['id']))) {
diff --git a/web/app/controllers/blogs.php b/web/app/controllers/blogs.php
index 80603aa..73e02ae 100644
--- a/web/app/controllers/blogs.php
+++ b/web/app/controllers/blogs.php
@@ -2,7 +2,7 @@
 	requirePHPLib('form');
 
 	if (!Auth::check()) {
-		becomeMsgPage(UOJLocale::get('need login'));
+		become403Page(UOJLocale::get('need login'));
 	}
 	
 	function echoBlogCell($blog) {
diff --git a/web/app/controllers/contest_inside.php b/web/app/controllers/contest_inside.php
index bb9c7b5..4785533 100644
--- a/web/app/controllers/contest_inside.php
+++ b/web/app/controllers/contest_inside.php
@@ -2,7 +2,7 @@
 	requirePHPLib('form');
 
 	if (!Auth::check()) {
-		becomeMsgPage(UOJLocale::get('need login'));
+		become403Page(UOJLocale::get('need login'));
 	}
 	
 	if (!validateUInt($_GET['id']) || !($contest = queryContest($_GET['id']))) {
diff --git a/web/app/controllers/contest_manage.php b/web/app/controllers/contest_manage.php
index a1a7af3..0955b28 100644
--- a/web/app/controllers/contest_manage.php
+++ b/web/app/controllers/contest_manage.php
@@ -2,7 +2,7 @@
 	requirePHPLib('form');
 
 	if (!Auth::check()) {
-		becomeMsgPage(UOJLocale::get('need login'));
+		become403Page(UOJLocale::get('need login'));
 	}
 
 	if (!validateUInt($_GET['id']) || !($contest = queryContest($_GET['id']))) {
diff --git a/web/app/controllers/contest_members.php b/web/app/controllers/contest_members.php
index 11bbf70..8f01d1d 100644
--- a/web/app/controllers/contest_members.php
+++ b/web/app/controllers/contest_members.php
@@ -2,7 +2,7 @@
 	requirePHPLib('form');
 
 	if (!Auth::check()) {
-		becomeMsgPage(UOJLocale::get('need login'));
+		become403Page(UOJLocale::get('need login'));
 	}
 
 	if (!validateUInt($_GET['id']) || !($contest = queryContest($_GET['id']))) {
diff --git a/web/app/controllers/contests.php b/web/app/controllers/contests.php
index 634f332..1440787 100644
--- a/web/app/controllers/contests.php
+++ b/web/app/controllers/contests.php
@@ -2,7 +2,7 @@
 	requirePHPLib('form');
 
 	if (!Auth::check()) {
-		becomeMsgPage(UOJLocale::get('need login'));
+		become403Page(UOJLocale::get('need login'));
 	}
 
 	$upcoming_contest_name = null;
diff --git a/web/app/controllers/download.php b/web/app/controllers/download.php
index dc41382..6c47d3b 100644
--- a/web/app/controllers/download.php
+++ b/web/app/controllers/download.php
@@ -2,7 +2,7 @@
 	requirePHPLib('judger');
 
 	if (!Auth::check()) {
-		becomeMsgPage(UOJLocale::get('need login'));
+		become403Page(UOJLocale::get('need login'));
 	}
 
 	switch ($_GET['type']) {
diff --git a/web/app/controllers/faq.php b/web/app/controllers/faq.php
index 6746ce9..cf3ea12 100644
--- a/web/app/controllers/faq.php
+++ b/web/app/controllers/faq.php
@@ -3,7 +3,7 @@
 	requireLib('mathjax');
 
 	if (!Auth::check()) {
-		becomeMsgPage(UOJLocale::get('need login'));
+		become403Page(UOJLocale::get('need login'));
 	}
 
 	echoUOJPageHeader(UOJLocale::get('help'));
diff --git a/web/app/controllers/hack.php b/web/app/controllers/hack.php
index 290c5bf..1179f57 100644
--- a/web/app/controllers/hack.php
+++ b/web/app/controllers/hack.php
@@ -2,7 +2,7 @@
 	requirePHPLib('form');
 
 	if (!Auth::check()) {
-		becomeMsgPage(UOJLocale::get('need login'));
+		become403Page(UOJLocale::get('need login'));
 	}
 
 	if (!validateUInt($_GET['id']) || !($hack = queryHack($_GET['id']))) {
diff --git a/web/app/controllers/hack_list.php b/web/app/controllers/hack_list.php
index 8f33e39..d43c269 100644
--- a/web/app/controllers/hack_list.php
+++ b/web/app/controllers/hack_list.php
@@ -1,6 +1,6 @@
 <?php
 	if (!Auth::check()) {
-		becomeMsgPage(UOJLocale::get('need login'));
+		become403Page(UOJLocale::get('need login'));
 	}
 
 	$conds = array();
diff --git a/web/app/controllers/problem.php b/web/app/controllers/problem.php
index f4d105c..3d70422 100644
--- a/web/app/controllers/problem.php
+++ b/web/app/controllers/problem.php
@@ -3,7 +3,7 @@
 	requirePHPLib('judger');	
 
 	if (!Auth::check()) {
-		becomeMsgPage(UOJLocale::get('need login'));
+		become403Page(UOJLocale::get('need login'));
 	}
 
 	if (!validateUInt($_GET['id']) || !($problem = queryProblemBrief($_GET['id']))) {
diff --git a/web/app/controllers/problem_data_manage.php b/web/app/controllers/problem_data_manage.php
index 4e780b9..fdcabab 100644
--- a/web/app/controllers/problem_data_manage.php
+++ b/web/app/controllers/problem_data_manage.php
@@ -4,7 +4,7 @@
 	requirePHPLib('data');
 
 	if (!Auth::check()) {
-		becomeMsgPage(UOJLocale::get('need login'));
+		become403Page(UOJLocale::get('need login'));
 	}
 	
 	if (!validateUInt($_GET['id']) || !($problem = queryProblemBrief($_GET['id']))) {
diff --git a/web/app/controllers/problem_managers_manage.php b/web/app/controllers/problem_managers_manage.php
index f90f2da..d27f884 100644
--- a/web/app/controllers/problem_managers_manage.php
+++ b/web/app/controllers/problem_managers_manage.php
@@ -2,7 +2,7 @@
 	requirePHPLib('form');
 
 	if (!Auth::check()) {
-		becomeMsgPage(UOJLocale::get('need login'));
+		become403Page(UOJLocale::get('need login'));
 	}
 	
 	if (!validateUInt($_GET['id']) || !($problem = queryProblemBrief($_GET['id']))) {
diff --git a/web/app/controllers/problem_set.php b/web/app/controllers/problem_set.php
index a301f56..01b89ca 100644
--- a/web/app/controllers/problem_set.php
+++ b/web/app/controllers/problem_set.php
@@ -4,7 +4,7 @@
 	requirePHPLib('data');
 
 	if (!Auth::check()) {
-		becomeMsgPage(UOJLocale::get('need login'));
+		become403Page(UOJLocale::get('need login'));
 	}
 	
 	if (isSuperUser($myUser) || isProblemManager($myUser) || isProblemUploader($myUser)) {
diff --git a/web/app/controllers/problem_statement_manage.php b/web/app/controllers/problem_statement_manage.php
index aae155f..09fa789 100644
--- a/web/app/controllers/problem_statement_manage.php
+++ b/web/app/controllers/problem_statement_manage.php
@@ -2,7 +2,7 @@
 	requirePHPLib('form');
 
 	if (!Auth::check()) {
-		becomeMsgPage(UOJLocale::get('need login'));
+		become403Page(UOJLocale::get('need login'));
 	}
 
 	if (!validateUInt($_GET['id']) || !($problem = queryProblemBrief($_GET['id']))) {
diff --git a/web/app/controllers/problem_statistics.php b/web/app/controllers/problem_statistics.php
index f5bf8bf..9c9fa8f 100644
--- a/web/app/controllers/problem_statistics.php
+++ b/web/app/controllers/problem_statistics.php
@@ -1,6 +1,6 @@
 <?php
 	if (!Auth::check()) {
-		becomeMsgPage(UOJLocale::get('need login'));
+		become403Page(UOJLocale::get('need login'));
 	}
 
 	if (!validateUInt($_GET['id']) || !($problem = queryProblemBrief($_GET['id']))) {
diff --git a/web/app/controllers/ranklist.php b/web/app/controllers/ranklist.php
index ba708ad..249edb3 100644
--- a/web/app/controllers/ranklist.php
+++ b/web/app/controllers/ranklist.php
@@ -1,6 +1,6 @@
 <?php
 	if (!Auth::check()) {
-		becomeMsgPage(UOJLocale::get('need login'));
+		become403Page(UOJLocale::get('need login'));
 	}
 
 	if (isset($_GET['type']) && $_GET['type'] == 'accepted') {
diff --git a/web/app/controllers/subdomain/blog/aboutme.php b/web/app/controllers/subdomain/blog/aboutme.php
index 19d5188..5875436 100644
--- a/web/app/controllers/subdomain/blog/aboutme.php
+++ b/web/app/controllers/subdomain/blog/aboutme.php
@@ -2,7 +2,7 @@
 	requirePHPLib('form');
 
 	if (!Auth::check()) {
-		becomeMsgPage(UOJLocale::get('need login'));
+		become403Page(UOJLocale::get('need login'));
 	}
 ?>
 <?php echoUOJPageHeader('关于我') ?>
diff --git a/web/app/controllers/subdomain/blog/archive.php b/web/app/controllers/subdomain/blog/archive.php
index ce9da53..018d223 100644
--- a/web/app/controllers/subdomain/blog/archive.php
+++ b/web/app/controllers/subdomain/blog/archive.php
@@ -2,7 +2,7 @@
 	requirePHPLib('form');
 
 	if (!Auth::check()) {
-		becomeMsgPage(UOJLocale::get('need login'));
+		become403Page(UOJLocale::get('need login'));
 	}
 	
 	$blogs_cond = "poster = '".UOJContext::userid()."'";
diff --git a/web/app/controllers/subdomain/blog/blog.php b/web/app/controllers/subdomain/blog/blog.php
index 82ffe04..26882b1 100644
--- a/web/app/controllers/subdomain/blog/blog.php
+++ b/web/app/controllers/subdomain/blog/blog.php
@@ -2,7 +2,7 @@
 	requirePHPLib('form');
 
 	if (!Auth::check()) {
-		becomeMsgPage(UOJLocale::get('need login'));
+		become403Page(UOJLocale::get('need login'));
 	}
 
 	if (!isset($_GET['id']) || !validateUInt($_GET['id']) || !($blog = queryBlog($_GET['id'])) || !UOJContext::isHis($blog)) {
diff --git a/web/app/controllers/subdomain/blog/blog_delete.php b/web/app/controllers/subdomain/blog/blog_delete.php
index 61c96bd..1253c47 100644
--- a/web/app/controllers/subdomain/blog/blog_delete.php
+++ b/web/app/controllers/subdomain/blog/blog_delete.php
@@ -2,7 +2,7 @@
 	requirePHPLib('form');
 
 	if (!Auth::check()) {
-		becomeMsgPage(UOJLocale::get('need login'));
+		become403Page(UOJLocale::get('need login'));
 	}
 	
 	if (!UOJContext::hasBlogPermission()) {
diff --git a/web/app/controllers/subdomain/blog/blog_write.php b/web/app/controllers/subdomain/blog/blog_write.php
index d197a52..661ca0f 100644
--- a/web/app/controllers/subdomain/blog/blog_write.php
+++ b/web/app/controllers/subdomain/blog/blog_write.php
@@ -2,7 +2,7 @@
 	requirePHPLib('form');
 
 	if (!Auth::check()) {
-		becomeMsgPage(UOJLocale::get('need login'));
+		become403Page(UOJLocale::get('need login'));
 	}
 
 	if (!UOJContext::hasBlogPermission()) {
diff --git a/web/app/controllers/subdomain/blog/index.php b/web/app/controllers/subdomain/blog/index.php
index b33e993..4494476 100644
--- a/web/app/controllers/subdomain/blog/index.php
+++ b/web/app/controllers/subdomain/blog/index.php
@@ -1,6 +1,6 @@
 <?php
 	if (!Auth::check()) {
-		becomeMsgPage(UOJLocale::get('need login'));
+		become403Page(UOJLocale::get('need login'));
 	}
 
 	$blogs_pag = new Paginator(array(
diff --git a/web/app/controllers/subdomain/blog/slide.php b/web/app/controllers/subdomain/blog/slide.php
index 7872d68..53d942f 100644
--- a/web/app/controllers/subdomain/blog/slide.php
+++ b/web/app/controllers/subdomain/blog/slide.php
@@ -2,7 +2,7 @@
 	requirePHPLib('form');
 
 	if (!Auth::check()) {
-		becomeMsgPage(UOJLocale::get('need login'));
+		become403Page(UOJLocale::get('need login'));
 	}
 	
 	if (!isset($_GET['id']) || !validateUInt($_GET['id']) || !($blog = queryBlog($_GET['id'])) || !UOJContext::isHisSlide($blog)) {
diff --git a/web/app/controllers/subdomain/blog/slide_write.php b/web/app/controllers/subdomain/blog/slide_write.php
index 308b830..20da15e 100644
--- a/web/app/controllers/subdomain/blog/slide_write.php
+++ b/web/app/controllers/subdomain/blog/slide_write.php
@@ -2,7 +2,7 @@
 	requirePHPLib('form');
 
 	if (!Auth::check()) {
-		becomeMsgPage(UOJLocale::get('need login'));
+		become403Page(UOJLocale::get('need login'));
 	}
 	
 	if (!UOJContext::hasBlogPermission()) {
diff --git a/web/app/controllers/submission.php b/web/app/controllers/submission.php
index bf14345..9a7f697 100644
--- a/web/app/controllers/submission.php
+++ b/web/app/controllers/submission.php
@@ -3,7 +3,7 @@
 	requirePHPLib('judger');
 
 	if (!Auth::check()) {
-		becomeMsgPage(UOJLocale::get('need login'));
+		become403Page(UOJLocale::get('need login'));
 	}
 	
 	if (!validateUInt($_GET['id']) || !($submission = querySubmission($_GET['id']))) {
diff --git a/web/app/controllers/submission_status_details.php b/web/app/controllers/submission_status_details.php
index 2b2a2da..06d1909 100644
--- a/web/app/controllers/submission_status_details.php
+++ b/web/app/controllers/submission_status_details.php
@@ -1,7 +1,7 @@
 <?php
 
 if (!Auth::check()) {
-	becomeMsgPage(UOJLocale::get('need login'));
+	become403Page(UOJLocale::get('need login'));
 }
 
 if (!is_array($_GET['get'])) {
diff --git a/web/app/controllers/submissions_list.php b/web/app/controllers/submissions_list.php
index e43acef..c3fdfce 100644
--- a/web/app/controllers/submissions_list.php
+++ b/web/app/controllers/submissions_list.php
@@ -1,6 +1,6 @@
 <?php
 	if (!Auth::check()) {
-		becomeMsgPage(UOJLocale::get('need login'));
+		become403Page(UOJLocale::get('need login'));
 	}
 
 	$conds = array();
diff --git a/web/app/controllers/user_info.php b/web/app/controllers/user_info.php
index 812afc6..ecab8b4 100644
--- a/web/app/controllers/user_info.php
+++ b/web/app/controllers/user_info.php
@@ -1,6 +1,6 @@
 <?php
 	if (!Auth::check()) {
-		becomeMsgPage(UOJLocale::get('need login'));
+		become403Page(UOJLocale::get('need login'));
 	}
 
 	$username = $_GET['username'];
diff --git a/web/app/libs/uoj-html-lib.php b/web/app/libs/uoj-html-lib.php
index 685f24e..57907ea 100644
--- a/web/app/libs/uoj-html-lib.php
+++ b/web/app/libs/uoj-html-lib.php
@@ -65,13 +65,13 @@ function becomeMsgPage($msg, $title = '消息') {
 		die();
 	}
 }
-function become404Page() {
+function become404Page($message = '未找到页面。') {
 	header($_SERVER['SERVER_PROTOCOL'] . " 404 Not Found", true, 404);
-	becomeMsgPage('<div class="text-center"><div style="font-size:233px">404</div><p>唔……未找到该页面……你是从哪里点进来的……&gt;_&lt;……</p></div>', '404');
+	becomeMsgPage('<div class="text-center"><div style="font-size:150px">404</div><p>' . $message . '</p></div>', '404');
 }
-function become403Page() {
+function become403Page($message = '访问被拒绝，您可能需要适当的权限以访问此页面。') {
 	header($_SERVER['SERVER_PROTOCOL'] . " 403 Forbidden", true, 403); 
-	becomeMsgPage('<div class="text-center"><div style="font-size:233px">403</div><p>禁止入内！ T_T</p></div>', '403');
+	becomeMsgPage('<div class="text-center"><div style="font-size:150px">403</div><p>' . $message . '</p></div>', '403');
 }
 
 function getUserLink($username) {